Skip to content

Update testing framework #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

kwstannard
Copy link

Improvements:

  • Testing is now a matrix of ruby versions against rails versions.
  • I believe tests will be faster since dependencies are installed at image build.
  • fixed flaking specs
  • fixed a bunch of warnings

Future:

Once I am maintainer I will setup a CI/CD process utilizing bin/test.

- Created new bin/test executable to run the tests.
- Cut unused Appraisal gem.
- Cut roadshow
- Updated the tests to run against more modern dependencies.
- Fixed some failures caused by colorization of outputs.
At some point IRB helper_methods gained `reload!` that operates exactly
like the defined method. So, lets just use that.
routes related tests were failing for two reasons:

- order dependencies between tests utilizing routes.rb and tests
  utilizing in file routes.
- automatically reloading routes at the top of process.

The routes file is always loaded by rails, so I think removing the thing
should be good. Tests still work anyways.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant