Skip to content

build: compile with C++20 #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

mpwarres
Copy link
Contributor

std=c++20 is used by both V8 and Envoy. proxy-wasm-cpp-host needs to switch to use it in order to build with recent versions of V8. This will also reduce build surprises when importing proxy-wasm-cpp-host into Envoy.

This PR is stacked on top of #438, and obsoletes #411.

mpwarres added 3 commits July 15, 2025 06:21
Signed-off-by: Michael Warres <[email protected]>
Signed-off-by: Michael Warres <[email protected]>
std=c++20 is used by both v8 and Envoy. Switching to use it is necessary to build with more recent versions of v8, and will also reduce overall build surprises when importing proxy-wasm-cpp-host into Envoy.

Signed-off-by: Michael Warres <[email protected]>
@leonm1
Copy link
Contributor

leonm1 commented Jul 15, 2025

I was able to successfully run env CC=/usr/bin/clang-12 CXX=/usr/bin/clang++-12 bazel build --config clang-tidy --define engine=multi --copt=-DPROXY_WASM_VERIFY_WITH_ED25519_PUBKEY=\"$(xxd -p -c 256 test/test_data/signature_key1.pub | cut -b9-)\" //... locally without any findings, so I will chalk the error up to a github runner issue and punt it to later / a separate issue.

@leonm1 leonm1 mentioned this pull request Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants