This repository was archived by the owner on Dec 9, 2025. It is now read-only.
Support non-zero minutes in the timestamp offset for JSON.#367
Merged
haberman merged 1 commit intoprotocolbuffers:masterfrom Feb 3, 2021
Merged
Support non-zero minutes in the timestamp offset for JSON.#367haberman merged 1 commit intoprotocolbuffers:masterfrom
haberman merged 1 commit intoprotocolbuffers:masterfrom
Conversation
Member
Author
|
I'm not sure where this compile failure came from, but it has nothing to do with this PR: |
gerben-s
approved these changes
Feb 2, 2021
3cae10c to
f7ed1f2
Compare
haberman
added a commit
to haberman/protobuf
that referenced
this pull request
Feb 3, 2021
haberman
added a commit
to protocolbuffers/protobuf
that referenced
this pull request
Feb 4, 2021
* Updated upb to allow nonzero offset minutes in JSON timestamps. This is to pick up protocolbuffers/upb#367 * Reverted error message change. * Fixed quote chars.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to address protocolbuffers/protobuf#8071