Fixed clone for Message, RepeatedField, and MapField.#8245
Merged
haberman merged 1 commit intoprotocolbuffers:masterfrom Feb 2, 2021
Merged
Fixed clone for Message, RepeatedField, and MapField.#8245haberman merged 1 commit intoprotocolbuffers:masterfrom
haberman merged 1 commit intoprotocolbuffers:masterfrom
Conversation
Also updated the code to use a TypeInfo struct for convenient passing of type and desc together. This simplified a lot of code and made this change easier to write.
gerben-s
reviewed
Feb 2, 2021
Contributor
gerben-s
left a comment
gerben-s
left a comment
There was a problem hiding this comment.
What exactly went wrong and how does this fix it?
Member
Author
gerben-s
approved these changes
Feb 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updated the code to use a TypeInfo struct for convenient
passing of type and desc together. This simplified a lot of code
and made this change easier to write.
Fixes #8233