Allow FileDescriptors to be parsed with extension registries#8220
Allow FileDescriptors to be parsed with extension registries#8220jtattermusch merged 2 commits intoprotocolbuffers:masterfrom
Conversation
…ue is the default Fixes protocolbuffers#8218.
This is important when parsing descriptor sets that contain extensions. (The alternative is to get the descriptor bytes again for individual elements, e.g. message descriptors, and reparse them with the appropriate extensions. It's really ugly.)
|
(First commit is from #8219.) |
jtattermusch
left a comment
jtattermusch
left a comment
There was a problem hiding this comment.
LGTM, but wondering what the immediate use is. Are you planning to write a protoc plugin in pure C#?
|
We already have a protoc plugin in pure C#: https://github.com/googleapis/gapic-generator-csharp Additionally, we're working on an "API index" which will parse protobuf descriptor sets for protos in https://github.com/googleapis/googleapis |
|
#8220 |
Ah, nice, I did not realize that.
SG! |
|
I looked at the test failures and they seem unrelated. The Windows C# failure also exists on master. |
5 participants
This allows for much cleaner handling of extensions in dynamic environments such as when writing a protoc plugin.