Fix parsing negative Int32Value that crosses segment boundary#8035
Merged
jtattermusch merged 2 commits intoprotocolbuffers:masterfrom Nov 13, 2020
Merged
Conversation
Contributor
Author
Contributor
|
Looks like the bug was originally introduced already in https://github.com/protocolbuffers/protobuf/pull/6843/files#diff-d740c4c5c32b30dbd921e0d61adac31089322bceaa2aa34b6b3020951817779eR851 (and it stayed around when moving the code to @chrisdunelm since you are the author of #6843, can you please review? |
Contributor
|
@acozzette I believe this is a release blocker - feel free to also review. |
jtattermusch
approved these changes
Nov 13, 2020
Contributor
jtattermusch
left a comment
jtattermusch
left a comment
There was a problem hiding this comment.
LGTM, thanks for the quick fix.
This was referenced Nov 13, 2020
acozzette
pushed a commit
to acozzette/protobuf
that referenced
this pull request
Nov 13, 2020
acozzette
pushed a commit
that referenced
this pull request
Nov 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8027