Skip to content

Add target_compatible_with parameter to proto_toolchain in Bazel rules #22429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jagub2 wants to merge 1 commit into from
Closed

Add target_compatible_with parameter to proto_toolchain in Bazel rules #22429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions bazel/toolchains/proto_toolchain.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ The macro additionally creates toolchain target when toolchain_type is given.
load("//bazel/private:proto_toolchain_rule.bzl", _proto_toolchain_rule = "proto_toolchain")
load("//bazel/private:toolchain_helpers.bzl", "toolchains")

def proto_toolchain(*, name, proto_compiler, exec_compatible_with = []):
def proto_toolchain(*, name, proto_compiler, exec_compatible_with = [], target_compatible_with = []):
"""Creates a proto_toolchain and toolchain target for proto_library.

Toolchain target is suffixed with "_toolchain".
Expand All @@ -22,13 +22,14 @@ def proto_toolchain(*, name, proto_compiler, exec_compatible_with = []):
name: name of the toolchain
proto_compiler: (Label) of either proto compiler sources or prebuild binaries
exec_compatible_with: ([constraints]) List of constraints the prebuild binary is compatible with.
target_compatible_with: ([constraints]) List of constraints the target it is compatible with.
"""
_proto_toolchain_rule(name = name, proto_compiler = proto_compiler)

native.toolchain(
name = name + "_toolchain",
toolchain_type = toolchains.PROTO_TOOLCHAIN,
exec_compatible_with = exec_compatible_with,
target_compatible_with = [],
target_compatible_with = target_compatible_with,
toolchain = name,
)
Loading