Automated rollback of commit f9863dfd3c98278e703be0e3c19ded2d09e60fde.#21355
Merged
Automated rollback of commit f9863dfd3c98278e703be0e3c19ded2d09e60fde.#21355
Conversation
PiperOrigin-RevId: 749053436
Contributor
|
How was this missed when the PR was approved? I approved the PR so I want to make sure this doesn't happen again! |
Member
Author
|
The test that caught this was a continuous-only test, so didn't run on presubmit. Adding #test-continuous to the PR description would force continuous-only tests to run on presubmit anyways. On our side, we noticed this was failing a bit late, but these run hourly so we def could've caught this earlier. |
haberman
approved these changes
Apr 18, 2025
Contributor
|
@zhangskz so would the next steps be for me to try and debug the failing continuous tests and then resubmit the PR? |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 749053436