Fix lite classes in the protobuf-java Maven release to be JDK8 compat…#20843
Merged
Fix lite classes in the protobuf-java Maven release to be JDK8 compat…#20843
Conversation
…ible. Adds LITE_SRCS to core_bundle which seems to be sufficient to ensure these are compiled targeting Java 8 in //java/core:core_mvn Bazel 7. Note this changes the output of `//java/core:core_bundle`, which should only be used for `//java/core:core_mvn` anyways. This seems to have been broken originally by commit (c820dd0) when using bazel 7 image. Fixes #20580 PiperOrigin-RevId: 740372071
zhangskz
requested review from
honglooker and
shaod2
and removed request for
a team and
shaod2
honglooker
approved these changes
Mar 26, 2025
Contributor
|
grazie~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ible.
Adds LITE_SRCS to core_bundle which seems to be sufficient to ensure these are compiled targeting Java 8 in //java/core:core_mvn Bazel 7. Note this changes the output of
//java/core:core_bundle, which should only be used for//java/core:core_mvnanyways.This seems to have been broken originally by commit (c820dd0) when using bazel 7 image.
Fixes #20580
PiperOrigin-RevId: 740372071
Cherry-pick 47b60e9