Fix python codegen crash when C++ features are used.#20577
Merged
mkruskal-google merged 1 commit into30.xfrom Mar 6, 2025
Merged
Fix python codegen crash when C++ features are used.#20577mkruskal-google merged 1 commit into30.xfrom
mkruskal-google merged 1 commit into30.xfrom
Conversation
What we actually want to prevent is any future use of non-enum features or python-specific features which don't exist today. If other language features are present we can safely strip them from the python gencode. We also reserve an extension number for the future python features in descriptor.proto PiperOrigin-RevId: 733885839
mkruskal-google
requested review from
anandolee and
zhangskz
and removed request for
a team
zhangskz
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What we actually want to prevent is any future use of non-enum features or python-specific features which don't exist today. If other language features are present we can safely strip them from the python gencode. We also reserve an extension number for the future python features in descriptor.proto
PiperOrigin-RevId: 733885839