Fix a python bug when assign an empty Struct at creation.#18977
Merged
zhangskz merged 1 commit intoprotocolbuffers:29.xfrom Oct 24, 2024
anandolee:29.x
Merged
Fix a python bug when assign an empty Struct at creation.#18977zhangskz merged 1 commit intoprotocolbuffers:29.xfrom anandolee:29.x
zhangskz merged 1 commit intoprotocolbuffers:29.xfrom
anandolee:29.x
Conversation
PiperOrigin-RevId: 689211445
anandolee
requested review from
ericsalo,
mkruskal-google and
zhangskz
and removed request for
a team and
ericsalo
zhangskz
approved these changes
Oct 24, 2024
zhangskz
added
the
🅰️ safe for tests
Member
|
Cherry-pick to 25.x as well? |
github-actions
bot
removed
the
🅰️ safe for tests
Contributor
Author
|
25.x does not have this issue. It is only introduced since 28 |
Member
|
Thanks for confirming! |
dongjoon-hyun
pushed a commit
to apache/spark
that referenced
this pull request
Dec 16, 2024
### What changes were proposed in this pull request? This PR aims to upgrade protobuf Python package from 5.28.3 to 5.29.1. ### Why are the changes needed? To bring the latest bug fixes, such as - Fix a python bug when assign an empty Struct at creation. (protocolbuffers/protobuf#18977) (protocolbuffers/protobuf@bb0d575), this one only introduced since 5.28.x - Fix cord handling in DynamicMessage and oneofs. (protocolbuffers/protobuf@9e8b30c) - Fix packed reflection handling bug in edition 2023. (protocolbuffers/protobuf@4c92328) - Fix ContainerBase::DeepCopy to not modify the source object. (protocolbuffers/protobuf@9fa1f4f) Full release notes as follows: - https://github.com/protocolbuffers/protobuf/releases/tag/v29.0-rc1 - https://github.com/protocolbuffers/protobuf/releases/tag/v29.0-rc2 - https://github.com/protocolbuffers/protobuf/releases/tag/v29.0-rc3 - https://github.com/protocolbuffers/protobuf/releases/tag/v29.0 - https://github.com/protocolbuffers/protobuf/releases/tag/v29.1 - https://pypi.org/project/protobuf/5.29.1/ ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass Github Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #49170 from LuciferYang/protobuf-python-5.29.1. Lead-authored-by: yangjie01 <yangjie01@baidu.com> Co-authored-by: YangJie <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 689211445
cherry-pick 47613cf