Cherry-pick: Fix Bazel dependency cycle issue affecting Kythe#18768
Merged
acozzette merged 1 commit intoprotocolbuffers:29.xfrom Oct 10, 2024
Merged
Cherry-pick: Fix Bazel dependency cycle issue affecting Kythe#18768acozzette merged 1 commit intoprotocolbuffers:29.xfrom
acozzette merged 1 commit intoprotocolbuffers:29.xfrom
Conversation
The fact that our `:protobuf_nowkt` target actually does depend on the well-known types is causing a dependency cycle for Kythe. This fixes that so that `:protobuf_nowkt` no longer depends on the well-known types. PiperOrigin-RevId: 684160567
acozzette
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
mkruskal-google
approved these changes
Oct 10, 2024
acozzette
changed the title
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fact that our
:protobuf_nowkttarget actually does depend on the well-known types is causing a dependency cycle for Kythe. This fixes that so that:protobuf_nowktno longer depends on the well-known types.PiperOrigin-RevId: 684160567