Fix cord handling in DynamicMessage and oneofs.#18374
Merged
mkruskal-google merged 6 commits into27.xfrom Sep 18, 2024
Merged
Conversation
This fixes a memory corruption vulnerability for anyone using cord with dynamically built descriptor pools.
zhangskz
requested review from
JasonLunn,
anandolee,
deannagarcia,
googleberg,
mkruskal-google,
shaod2 and
tonyliaoss
and removed request for
a team,
JasonLunn,
anandolee,
deannagarcia and
tonyliaoss
zhangskz
force-pushed
the
cp-cord-fix-27
branch
2 times, most recently
from
0b2a5aa to
189b206
Compare
* Move -Werror to our test/dev bazelrc files.
Putting it into BUILD files unintentionally forces it on all our downstream users. Instead, we just want to enable this during testing and let them choose for themselves in their builds.
Note, that this expands the scope of -Werror to our entire repo for CI, so a bunch of fixes and opt-outs had to be applied to get this change passing.
Closed #14714
PiperOrigin-RevId: 666903224
* Fix extra warnings on 28.x
* Fix zlib issues on macos
* Second try at zlib/macos issues
* Only disable deprecated-non-prototype on macos-14
zhangskz
force-pushed
the
cp-cord-fix-27
branch
from
189b206 to
f38b4f4
Compare
googleberg
approved these changes
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a memory corruption vulnerability for anyone using cord with dynamically built descriptor pools.