fix: do not throw deprecated warning on field getters for default values#17788
Closed
bshaffer wants to merge 8 commits intoprotocolbuffers:mainfrom
Closed
fix: do not throw deprecated warning on field getters for default values#17788bshaffer wants to merge 8 commits intoprotocolbuffers:mainfrom
bshaffer wants to merge 8 commits intoprotocolbuffers:mainfrom
Conversation
This was referenced Aug 12, 2024
Closed
bshaffer
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
bshaffer
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
mkruskal-google
approved these changes
Aug 12, 2024
bshaffer
commented
Aug 12, 2024
Contributor
Author
bshaffer
left a comment
bshaffer
left a comment
There was a problem hiding this comment.
there's enough complexity around getting the field to even check if it's default... for instance, $this->readOneof should be called instead of the property name for "OneOf fields", and $this->readWrapperValue should be called for "wrapped" fields
bshaffer
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
bshaffer
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
bshaffer
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
mkruskal-google
approved these changes
Aug 20, 2024
bshaffer
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
mkruskal-google
approved these changes
Aug 20, 2024
bshaffer
added a commit
to bshaffer/protobuf
that referenced
this pull request
Apr 1, 2025
…t values (protocolbuffers#17788) backports fix for protocolbuffers#13428 to 25.x branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #13428
Wraps deprecated field getters in a conditional to see if the value has been set before throwing the warning. This is because this method is used internally, so users can get deprecated warnings even when they are not using the field.