Add Compiler Condition to use inline assembly optimizations with ARM64 for Compatibility with MSVC#17671
Closed
dsmith111 wants to merge 4 commits intoprotocolbuffers:mainfrom
Closed
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
7 tasks
Contributor
Author
|
Hey @fowles, just a habit when contributing to open-source (I know teams change), want to check in and make sure you're still an active maintainer here! @acozzette, adding the other majority git-blame owner as well. |
acozzette
approved these changes
Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#17665
Problem
google\protobuf\parse_context.h(721,10): error C2059: syntax error: ':'google\protobuf\parse_context.h(898,14): error C3861: 'Ubfx7': identifier not foundThe latest protobuf versions fail to compile with MSVC on Windows ARM64 architecture.
https://learn.microsoft.com/en-us/cpp/assembler/inline/writing-functions-with-inline-assembly?view=msvc-170
Solution
As inline assembly for win ARM64 with MSVC as a compiler is not supported (even ARM specific assembly functions), a term has been added to the conditions in parse_context.h to prevent the assembly optimizations for arm64 from executing if the compiler is MSVC.
Tested by compiling protobuf with MSVC on Windows ARM64 and AMD64 architecture. Compilation was a success.