Skip to content

Add bigdecimal to dependencies#16379

Closed
JasonLunn wants to merge 1 commit intomainfrom
support_ruby_3.4.x
Closed

Add bigdecimal to dependencies#16379
JasonLunn wants to merge 1 commit intomainfrom
support_ruby_3.4.x

Conversation

@JasonLunn
Copy link
Contributor

@JasonLunn JasonLunn commented Apr 2, 2024

In Ruby 3.4, bigdecimal is no longer built in. See announcement in Ruby 3.3 release notes.

@JasonLunn JasonLunn added the ruby label Apr 2, 2024
@JasonLunn JasonLunn requested review from a team as code owners April 2, 2024 16:09
@JasonLunn JasonLunn requested review from ericsalo and zhangskz and removed request for a team April 2, 2024 16:09
@JasonLunn JasonLunn changed the title Add bigdecimal to dependencies in preparation for Ruby 3.4 where it is no longer built in. Add bigdecimal to dependencies Apr 2, 2024
Copy link
Member

@zhangskz zhangskz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this be disruptive for users? We probably want to make sure to include this in the release notes at least

@JasonLunn
Copy link
Contributor Author

It should not be disruptive for users, but I agree it deserves to make it to the release notes. https://rubygems.org/gems/bigdecimal is a mature gem with tens of millions of installs and is something we already have a dependency on, we're just used to getting said dependency from the ruby installation itself, rather than having to explicitly treat it as a gem. It has a platform specific implementation for JRuby but is otherwise a pure-Ruby gem that is architecture independent. This is part of a larger effort on the part of the Ruby language maintainers to push more of the current standard library into optional gems.

@copybara-service copybara-service bot closed this in d810ef6 Apr 3, 2024
elvisdukaj pushed a commit to elvisdukaj/protobuf that referenced this pull request Apr 3, 2024
In Ruby 3.4, `bigdecimal` is no longer built in. See announcement in [Ruby 3.3 release notes](https://www.ruby-lang.org/en/news/2023/12/25/ruby-3-3-0-released/#:~:text=base64-,bigdecimal,-csv).

Closes protocolbuffers#16379

COPYBARA_INTEGRATE_REVIEW=protocolbuffers#16379 from protocolbuffers:support_ruby_3.4.x 084063b
PiperOrigin-RevId: 621362101
deannagarcia pushed a commit to deannagarcia/protobuf that referenced this pull request Jun 20, 2024
In Ruby 3.4, `bigdecimal` is no longer built in. See announcement in [Ruby 3.3 release notes](https://www.ruby-lang.org/en/news/2023/12/25/ruby-3-3-0-released/#:~:text=base64-,bigdecimal,-csv).

Closes protocolbuffers#16379

COPYBARA_INTEGRATE_REVIEW=protocolbuffers#16379 from protocolbuffers:support_ruby_3.4.x 084063b
PiperOrigin-RevId: 621362101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants