[Ruby] Delegate difference, intersection, union from RepeatedField to Array#15652
Closed
marianosimone wants to merge 1 commit intoprotocolbuffers:mainfrom
Closed
[Ruby] Delegate difference, intersection, union from RepeatedField to Array#15652marianosimone wants to merge 1 commit intoprotocolbuffers:mainfrom
marianosimone wants to merge 1 commit intoprotocolbuffers:mainfrom
Conversation
JasonLunn
added
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
JasonLunn
approved these changes
Jan 31, 2024
JasonLunn
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
Contributor
Author
|
cc @JasonLunn the failed build task seems unrelated |
Member
|
Triggered rerun on the macOS failure which is a known flake. |
deannagarcia
pushed a commit
to deannagarcia/protobuf
that referenced
this pull request
Jun 20, 2024
… Array (protocolbuffers#15652) Coming from [[protobuf/issues/15180] [Ruby] Support for currently ignored Array methods in `RepeatedField`](protocolbuffers#15180) This adds a couple of `Array` methods to what gets delegated from `RepeatedField`. - `intersection`, because `|` was already delegated - `union`, because `&` was already delegated - `difference`, because `-` was already delegated Closes protocolbuffers#15652 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#15652 from marianosimone:delegate_rb_array_methods 2971981 PiperOrigin-RevId: 604534655
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coming from [protobuf/issues/15180] [Ruby] Support for currently ignored Array methods in
RepeatedFieldThis adds a couple of
Arraymethods to what gets delegated fromRepeatedField.intersection, because|was already delegatedunion, because&was already delegateddifference, because-was already delegated