Closed
Conversation
ZhongRuoyu
requested review from
acozzette and
anandolee
and removed request for
a team
In 501ecec the `python/BUILD` Bazel build file was introduced. On a case-insensitive filesystem (default on e.g. macOS), it conflicts with `setup.py`'s default behaviour, which creates a `build` directory for build artifacts. Fix that by renaming the `BUILD` file to `BUILD.bazel`. Signed-off-by: Ruoyu Zhong <zhongruoyu@outlook.com>
ZhongRuoyu
force-pushed
the
setup.py-fix
branch
from
e90075c to
88034fd
Compare
acozzette
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
|
Thank you for the pull request. There's a change we need to make internally to make this possible, so let me do that myself and I will send out a change for this. |
acozzette
pushed a commit
to acozzette/protobuf
that referenced
this pull request
Nov 6, 2023
This should address the issue in protocolbuffers#14600 by avoiding a conflict on with the `build` directory created by setup.py on a case-insensitive filesystem. Closes protocolbuffers#14600. PiperOrigin-RevId: 579859556
acozzette
pushed a commit
that referenced
this pull request
Nov 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 501ecec the
python/BUILDBazel build file was introduced. On a case-insensitive filesystem (default on e.g. macOS), it conflicts withsetup.py's default behaviour, which creates abuilddirectory for build artifacts.Fix that by renaming the
BUILDfile toBUILD.bazel.