Printer: Include Abseil's str_cat.h for absl::AlphaNum#14054
Merged
mkruskal-google merged 1 commit intoprotocolbuffers:24.xfrom Sep 12, 2023
Merged
Printer: Include Abseil's str_cat.h for absl::AlphaNum#14054mkruskal-google merged 1 commit intoprotocolbuffers:24.xfrom
Printer: Include Abseil's str_cat.h for absl::AlphaNum#14054mkruskal-google merged 1 commit intoprotocolbuffers:24.xfrom
Conversation
No need to touch Bazel/CMake files, as they already depend on Abseil strings. PiperOrigin-RevId: 564640299
mkruskal-google
requested review from
sbenzaquen
and removed request for
a team
mkruskal-google
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
zhangskz
approved these changes
Sep 12, 2023
veblush
added a commit
to grpc/grpc
that referenced
this pull request
Sep 13, 2023
This is to have protocolbuffers/protobuf#14054 which is required to make abseil-at-head test pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need to touch Bazel/CMake files, as they already depend on Abseil strings.
PiperOrigin-RevId: 564640299