gracefully handle weird placement of linebreaks around comments#10660
Merged
fowles merged 1 commit intoprotocolbuffers:mainfrom Sep 27, 2022
Merged
gracefully handle weird placement of linebreaks around comments#10660fowles merged 1 commit intoprotocolbuffers:mainfrom
fowles merged 1 commit intoprotocolbuffers:mainfrom
Conversation
fowles
approved these changes
Sep 27, 2022
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
gracefully handle weird placement of linebreaks around comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds more robustness to the handling of comments, particularly inline comments, even in the face of unusual newline placement. See changed test cases to get a feel for the change in behavior.
Fixes #10648.