Python release for 5.29.0 has indent problem

[thatch]

If you run python -m compileall on any of the wheels for the latest release ~40 minutes ago, it will fail with:

Compiling 'google/protobuf/service.py'...
*** Sorry: IndentationError: unindent does not match any outer indentation level (service.py, line 78)

I can confirm there appears to be a missing space, but I don't see that file (under that name or contents) checked in.

[piotlinski]

Confirming that, it seems to be visible on the 29.x branch:

protobuf/python/google/protobuf/service.py

Line 78 in e0a3978

raise NotImplementedError

[ejona86]

That file has been deleted on main, but it is in the 29.x branch.

[ElisaRMA]

Just FYI, still faced this issue today when importing some packages. The version installed was the 5.29.0. Reverting to the previous version solved the problem :)

[..]/google/protobuf/service.py:78 raise NotImplementedError ^ IndentationError: unindent does not match any outer indentation level

[SebKleiner]

Hi, I still face this issue while installing 5.29.0

[miguelgfierro]

Confirming as well, it's breaking all our tests: recommenders-team/recommenders#2191

Crazy idea: it would be nice to test your library before making a release.

[miguelgfierro]

@anandolee @ejona86 you need to yank 5.29.0 https://pypi.org/project/protobuf/5.29.0/

[dionhaefner]

lmao @ the fact that this is still live 5 days later

$ pip install protobuf
$ python -c "import google.protobuf.service"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/dion/.virtualenvs/tempenv-2d0a294330027/lib/python3.10/site-packages/google/protobuf/service.py", line 78
    raise NotImplementedError
                             ^
IndentationError: unindent does not match any outer indentation level

[zhangskz]

This should be patched in v29.1 ~tomorrow. We are not planning on yanking v29.0 currently, since the issue is isolated to a long-deprecated API slated for removal. For now, we recommend not picking up v29.0 yet if you need compileall or if using the service.py (or ideally moving off of that since it'll be removed soon in v30.x).

Unfortunately the culprit change also removed the test that also would have caught it, as a side-effect of our removal of this API internally. We will consider adding tests with compileall to avoid similar test coverage problems in the future.