Ignore boolean keys in my.cnf. #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Below is valid MySQL config however mysqld_exporter fails to read it, because of the boolean keys. Config: ``` [client] user = root password = abc123 [mysql] skip-auto-rehash ``` Signed-off-by: Kamil Dziedzic <[email protected]>
arvenil
force-pushed
the
ignore-boolean-keys-in-my-cnf
branch
from
458f854 to
1db177c
Compare
|
What blocks it from merging? |
|
Sorry, got distracted. 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below is valid MySQL config however mysqld_exporter fails to read it,
because of the boolean keys.
Config:
For reference: https://jira.percona.com/browse/PMM-2469