-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix errNotImplemented
reference
#1835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Arve Knudsen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Fixes a reference to the correct errNotImplemented
variable in the Darwin non-cgo memory collector stub.
- Replace the undefined
notImplementedErr
with the existingerrNotImplemented
ingetMemory
. - Ensures the stub compiles against the shared error constant.
Comments suppressed due to low confidence (1)
prometheus/process_collector_mem_nocgo_darwin.go:19
- Consider adding a unit test to verify that
getMemory
on Darwin without cgo returnserrNotImplemented
as expected, ensuring this stub behavior is covered.
return nil, errNotImplemented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for quick action.
Replace
notImplementedErr
reference witherrNotImplemented
in prometheus/process_collector_mem_nocgo_darwin.go, since the former doesn't exist any longer. This fixes compilation on Mac.