Remove support for external postprocessing filter definitions#453
Merged
Conversation
simu
added
the
breaking
simu
force-pushed
the
feat/remove-external-pp-filters
branch
from
1e9f6cb to
73781ac
Compare
simu
force-pushed
the
feat/remove-external-pp-filters
branch
from
73781ac to
8b5e670
Compare
corvus-ch
approved these changes
Apr 5, 2022
corvus-ch
left a comment
corvus-ch
left a comment
Contributor
There was a problem hiding this comment.
Yes, burn that old code but with fire 😛
We can completely remove `postprocess/inventory.py` since we now always get rendered inventory values from Reclass/Kapitan when reading filter definitions. Also, we remove the `test_postprocess_components_enabledref` test, because that test only made sense for external postprocessing filters without actually rendering the mocked inventory with Reclass.
simu
force-pushed
the
feat/remove-external-pp-filters
branch
from
8b5e670 to
7885a5e
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can completely remove
postprocess/inventory.pysince we now always get rendered inventory values from Reclass/Kapitan when reading filter definitions.Also, we remove the
test_postprocess_components_enabledreftest, because that test only made sense for external postprocessing filters without actually rendering the mocked inventory with Reclass.Relates #375
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog