Add support for component library aliases#447
Merged
Conversation
simu
force-pushed
the
feat/component-library-aliases
branch
6 times, most recently
from
4d57e57 to
8761413
Compare
simu
commented
Apr 4, 2022
|
|
||
|
|
||
| # pylint: disable=too-many-arguments | ||
| # pylint: disable=too-many-arguments disable=too-many-locals disable=too-many-statements |
Member
Author
There was a problem hiding this comment.
#448 will refactor component_compile() to make it significantly smaller.
corvus-ch
approved these changes
Apr 4, 2022
We use the keys of `parameters.components` to check for invalid prefixes.
simu
force-pushed
the
feat/component-library-aliases
branch
from
8761413 to
41368c3
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #417
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog