Conversation
3 tasks
simu
approved these changes
Mar 29, 2022
simu
left a comment
simu
left a comment
Member
There was a problem hiding this comment.
Strictly speaking this should probably be 2 PRs:
- "Update component template to support Podman out of the box" (
enhancement) - "Update Commodore Makefile to support Podman out of the box" (
change)
While it was already possible to use podman by setting the DOCKER_CMD env var, this was not enough for most commands. This commit adds support for Podman out of the box. If Docker is installed, it will be preferred over Podman to stay backwards-compatible. The `--userns=keep-id` flag is required on Podman to ensure that 1.) the process in the container can write to the mounted workdirs, and 2.) ensure files created by processes in the container have the correct owner and group IDs: The ones from the user running the Make tasks. Signed-off-by: Manuel Hutter <manuel@hutter.io>
mhutter
changed the title
mhutter
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While it was already possible to use podman by setting the DOCKER_CMD
env var, this was not enough for most commands.
This commit adds support for Podman out of the box. If Docker is
installed, it will be preferred over Podman to stay
backwards-compatible.
The
--userns=keep-idflag is required on Podman to ensure that 1.) theprocess in the container can write to the mounted workdirs, and 2.)
ensure files created by processes in the container have the correct owner
and group IDs: The ones from the user running the Make tasks.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog