Move component instantiation advertisement to _metadata.multi_instance#411
Merged
Conversation
simu
force-pushed
the
feat/multi-instance-in-metadata
branch
from
bc8ad22 to
49583b6
Compare
This commit moves the preferred location for components to advertise multi-instance support to `parameters.<component_name>._metadata.multi_instance`. The old parameter `parameters.<component_name>.multi_instance` is still supported, but Commodore emits a deprecation notice for each component which still uses the old parameter. Fixes #317
simu
force-pushed
the
feat/multi-instance-in-metadata
branch
from
49583b6 to
18fe5f6
Compare
glrf
approved these changes
Feb 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the preferred location for components to advertise multi-instance support to
parameters.<component_name>._metadata.multi_instance.The old parameter
parameters.<component_name>.multi_instanceis still supported, but Commodore emits a deprecation notice for each component which still uses the old parameter.Fixes #317
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog