Use absolute Docker Image URLs#396
Merged
Merged
Conversation
Especially on Podman systems, docker.io may not be the default. Be explicit where to pull images from by configuring a registry. Signed-off-by: Manuel Hutter <manuel@hutter.io>
simu
approved these changes
Dec 28, 2021
simu
left a comment
simu
left a comment
Member
There was a problem hiding this comment.
The modulesync-control template (https://github.com/projectsyn/modulesync-control/blob/master/moduleroot/Makefile.vars.mk.erb) should be updated as well, if the component template in Commodore is changed, otherwise modulesync will revert the absolute image URLs in the component template when components are onboarded to modulesync.
Contributor
Author
|
Good point, projectsyn/modulesync-control#53 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Especially on Podman systems, docker.io may not be the default, thus breaking image pulls.
Be explicit where to pull images from by configuring a registry.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog