Skip to content

Set explicit encoding to fix pylint warnings#361

Merged
bastjan merged 1 commit into
masterfrom
fix-pylint-warnings
Aug 24, 2021
Merged

Set explicit encoding to fix pylint warnings#361
bastjan merged 1 commit into
masterfrom
fix-pylint-warnings

Conversation

@bastjan

@bastjan bastjan commented Aug 24, 2021

Copy link
Copy Markdown
Member

This PR fixes newly added pylint warnings:

commodore/helpers.py:47:9: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)

Should we start to pin pylint to a fixed version?

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog

@bastjan bastjan added the change PR with a minor change which affects users label Aug 24, 2021
@bastjan bastjan marked this pull request as draft August 24, 2021 09:01
@bastjan bastjan force-pushed the fix-pylint-warnings branch from 8c5571a to 4462b7b Compare August 24, 2021 09:11
@bastjan bastjan marked this pull request as ready for review August 24, 2021 09:19
@bastjan bastjan requested review from corvus-ch and glrf August 24, 2021 09:19
@bastjan bastjan merged commit 21ce0b5 into master Aug 24, 2021
@bastjan bastjan deleted the fix-pylint-warnings branch August 24, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change PR with a minor change which affects users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants