Skip to content

Always fetch Kapitan dependencies#341

Merged
simu merged 1 commit into
masterfrom
feat/always-fetch-kapitan-deps
Jul 1, 2021
Merged

Always fetch Kapitan dependencies#341
simu merged 1 commit into
masterfrom
feat/always-fetch-kapitan-deps

Conversation

@simu

@simu simu commented Jun 29, 2021

Copy link
Copy Markdown
Member

Kapitan has an option force_fetch to always fetch and update dependencies specified in parameters.kapitan.dependencies.

This commit sets that option to True to ensure component dependencies are always updated to their latest upstream variants.

This change removes the sometimes unwanted Kapitan behavior to keep stale dependencies, if the component either doesn't properly store dependencies in a version-specific directory, or if dependencies are specified with moving versions (e.g. release-4.x for OCP4 alert rule manifests).

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog

@simu simu added the enhancement New feature or request label Jun 29, 2021
@simu simu requested review from ccremer and corvus-ch June 29, 2021 14:01
@ccremer

ccremer commented Jun 29, 2021

Copy link
Copy Markdown
Contributor

What is the implication to compiling with --local or --no-fetch-dependencies ?

@simu

simu commented Jun 29, 2021

Copy link
Copy Markdown
Member Author
  • just --local: We already fetched Kapitan deps in "regular" local mode, with this change we just ensure existing Kapitan dependency output files are overwritten
  • --local and --no-fetch-dependencies: No dependencies are fetched, so the flag doesn't have an effect at all
  • --no-fetch-dependencies without --local doesn't have an effect on the catalog compilation

Kapitan has an option `force_fetch` to always fetch and update
dependencies specified in `parameters.kapitan.dependencies`.

This commit sets that option to `True` to ensure component dependencies
are always updated to their latest upstream variants.

This change removes the sometimes unwanted Kapitan behavior to keep
stale dependencies, if the component either doesn't properly store
dependencies in a version-specific directory, or if dependencies are
specified with moving versions (e.g. `release-4.x` for OCP4 alert rule
manifests).
@simu simu force-pushed the feat/always-fetch-kapitan-deps branch from 182d2a3 to 6f109ce Compare June 30, 2021 06:17
@simu simu merged commit 2b27bbe into master Jul 1, 2021
@simu simu deleted the feat/always-fetch-kapitan-deps branch July 1, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants