Introduce inventory parameters for cluster and tenant display names#311
Merged
Conversation
simu
force-pushed
the
feat/display-name-params
branch
from
cb3f239 to
e6be4cd
Compare
ccremer
reviewed
Apr 28, 2021
simu
force-pushed
the
feat/display-name-params
branch
from
e6be4cd to
d214659
Compare
ccremer
approved these changes
Apr 28, 2021
This commit adds parameters `cluster.display_name` and `cluster.tenant_display_name` which can be used to insert the cluster's and tenant's display name in manifests. The commit also adds a new documentation page which lists all the inventory parameters which are managed by Commodore and injected during catalog compilation. Fixes #307.
simu
force-pushed
the
feat/display-name-params
branch
from
d214659 to
186cd80
Compare
simu
added a commit
that referenced
this pull request
Aug 8, 2023
We manually generate a `cluster/params.yml` in `component compile`. This
logic hasn't been updated to provide values for
`${cluster:display_name}` and `${cluster:tenant_display_name}` in #311.
This commit updates `component compile` to provide dummy values for
those variables and adjusts the component compilation tests to verify
that these variables are provided.
4 tasks
simu
added a commit
that referenced
this pull request
Aug 8, 2023
…package compile`
We manually generate a `cluster/params.yml` in `component compile` and
`package compile`. This logic hasn't been updated to provide values for
`${cluster:display_name}` and `${cluster:tenant_display_name}` in #311.
This commit updates `component compile` and `package compile` to provide
dummy values for those variables and adjusts the component compilation
tests to verify that these variables are provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds parameters
cluster.display_nameandcluster.tenant_display_namewhich can be used to insert the cluster's and tenant's display name in manifests.The commit also adds a new documentation page which lists all the inventory parameters which are managed by Commodore and injected during catalog compilation.
Fixes #307.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog