Correctly handle component versions which are tags#290
Merged
Conversation
Tags show up as heads in the remote, but without the remote name as prefix. Previously the code would then try to checkout a branch with the name of the tag. This commit makes the assumption that any heads in a remote which don't have the remote name as a prefix are tags, and handles checkout accordingly. To keep the things simple, tags are checked out in detached HEAD state.
srueg
approved these changes
Mar 12, 2021
The `checkout()` method has gotten quite unwieldy. This commit factors out the following methods: * method to calculate prefix of remote (e.g. "origin/") * method to find the default version for a component (the remote's default branch) if no explicit version is set * method to find a GitPython `Commit` for the specified version
simu
force-pushed
the
fix/component-version-tag
branch
from
df0bc27 to
4ccd661
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tags show up as heads in the remote, but without the remote name as prefix. Previously the code would then try to checkout a branch with the name of the tag.
This commit makes the assumption that any heads in a remote which don't have the remote name as a prefix are tags, and handles checkout accordingly.
To keep the things simple, tags are checked out in detached HEAD state.
Checklist