Inventory postprocessing filters#222
Merged
Merged
Conversation
simu
force-pushed
the
inventory-postprocessing-filters
branch
2 times, most recently
from
08e0a69 to
e4397a9
Compare
Member
Author
|
Still TODO:
|
simu
force-pushed
the
inventory-postprocessing-filters
branch
5 times, most recently
from
0d33c53 to
4989b8a
Compare
simu
force-pushed
the
inventory-postprocessing-filters
branch
4 times, most recently
from
f7124a1 to
1ccf2bb
Compare
srueg
approved these changes
Oct 29, 2020
Refactor postprocessing filter code in preparation for moving filter definitions into the inventory. Defining filters in the inventory will allow us to rely on Kapitan (and reclass) to resolve inventory references in the filter definitions. This commit changes some of the postprocessing filter execution internals to prepare the code base for an implementation which allows both styles of filter definitions (in the inventory and in postprocess/filters.yml) in a transitional period until all existing components have been updated. This commit does not yet introduce functionality to extract filters from the inventory, but refactors the internal filter dict contents to reduce the amount of required fields for filter definitions, especially for builtin filters.
Postprocessing filters can also be defined under `parameters.commodore.postprocess.filters` in component classes using mostly the same format as `postprocess/filters.py`. Notable changes to the filter definition format: Jsonnet filters need to provide the full path to the directory holding the filter definition (including the component directory) as `filterpath`. Filters which require the component name need to set it as `component` in the filter definition. Filters without `type` are not accepted if defined in the inventory.
Retroactively name postprocessing filters defined in `postprocess/filters.yml` "external" postprocessing filters.
simu
force-pushed
the
inventory-postprocessing-filters
branch
from
1ccf2bb to
88397eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #156
Checklist