More explicit error when failing to add component#183
Merged
simu merged 2 commits intoSep 16, 2020
Conversation
srueg
suggested changes
Sep 16, 2020
srueg
left a comment
srueg
left a comment
Contributor
There was a problem hiding this comment.
Please add a changelog entry.
simu
requested changes
Sep 16, 2020
simu
left a comment
simu
left a comment
Member
There was a problem hiding this comment.
Please make sure that exception handling is introduced to compensate for the removed code in relsymlink.
chrisglass
force-pushed
the
warn-user-when-outside-of-catalog
branch
from
f2057f1 to
d541dd0
Compare
Closed
Contributor
Author
Oops! Added. |
Member
Follow-up to come up with a concept for and refactor error handling across the whole code base: #184 |
simu
approved these changes
Sep 16, 2020
simu
reviewed
Sep 16, 2020
Should "component create" be called outside of a catalog, display some information in this regard to the user. The lower layer exception (FileNotFound) is not wrapped in the top-layer click.Exception() wrapper anymore in order to differentiate exception types.
chrisglass
force-pushed
the
warn-user-when-outside-of-catalog
branch
from
6a08e25 to
a409e45
Compare
Co-authored-by: Simon Gerber <gesimu@gmail.com>
chrisglass
force-pushed
the
warn-user-when-outside-of-catalog
branch
from
a409e45 to
e8135c2
Compare
srueg
approved these changes
Sep 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should "component create" be called outside of a catalog, display some
information in this regard to the user.
The lower layer exception (FileNotFound) is not wrapped in the top-layer
click.Exception() wrapper anymore in order to differentiate exception
types.
Checklist