Allow postprocessing filters to be disabled#155
Merged
Conversation
simu
added a commit
to projectsyn/component-keycloak
that referenced
this pull request
Jul 31, 2020
The current implementation allows configuring the following aspects of Keycloak: * The public hostname using either ingress or route * An initial admin user * Keycloak pod resource requests and limits * Additional Java options (JAVA_OPTS) * Prometheus monitoring using an existing prometheus-operator * Postgres database to use. By default a Bitnami Postgres is installed using the default storage class in the cluster. Note: Using an external database depends on the unreleased Commodore feature which supports making postprocessing filters optional, cf. github.com/projectsyn/commodore#155.
2 tasks
simu
added a commit
to projectsyn/component-keycloak
that referenced
this pull request
Jul 31, 2020
The current implementation allows configuring the following aspects of Keycloak: * The public hostname using either ingress or route * An initial admin user * Keycloak pod resource requests and limits * Additional Java options (JAVA_OPTS) * Prometheus monitoring using an existing prometheus-operator * Postgres database to use. By default a Bitnami Postgres is installed using the default storage class in the cluster. Note: Using an external database depends on the unreleased Commodore feature which supports making postprocessing filters optional, cf. projectsyn/commodore#155.
simu
added a commit
to projectsyn/component-keycloak
that referenced
this pull request
Jul 31, 2020
The current implementation allows configuring the following aspects of Keycloak: * The public hostname using either ingress or route * An initial admin user * Keycloak pod resource requests and limits * Additional Java options (JAVA_OPTS) * Prometheus monitoring using an existing prometheus-operator * Postgres database to use. By default a Bitnami Postgres is installed using the default storage class in the cluster. Note: Using an external database depends on the unreleased Commodore feature which supports making postprocessing filters optional, cf. projectsyn/commodore#155.
simu
added a commit
to projectsyn/component-keycloak
that referenced
this pull request
Jul 31, 2020
The current implementation allows configuring the following aspects of Keycloak: * The public hostname using either ingress or route * An initial admin user * Keycloak pod resource requests and limits * Additional Java options (JAVA_OPTS) * Prometheus monitoring using an existing prometheus-operator * Postgres database to use. By default a Bitnami Postgres is installed using the default storage class in the cluster. Note: Using an external database depends on the unreleased Commodore feature which supports making postprocessing filters optional, cf. projectsyn/commodore#155.
simu
force-pushed
the
postprocess-optional-disable
branch
2 times, most recently
from
8bbbfb5 to
778bbf1
Compare
Member
Author
|
Rebased on latest master after merging #154 |
srueg
suggested changes
Jul 31, 2020
simu
force-pushed
the
postprocess-optional-disable
branch
2 times, most recently
from
bcf8266 to
1eee3a8
Compare
This can be useful if we need to apply a postprocessing filter on a subchart of a Helm chart, e.g. Postgres for Keycloak. This commit refactors the existing reclass reference parsing for builtin filters to be more general-purpose, and applies the reference parsing and resolution to the whole filter dict.
simu
force-pushed
the
postprocess-optional-disable
branch
from
1eee3a8 to
b861411
Compare
srueg
approved these changes
Aug 3, 2020
simu
added a commit
to projectsyn/component-keycloak
that referenced
this pull request
Aug 3, 2020
The current implementation allows configuring the following aspects of Keycloak: * The public hostname using either ingress or route * An initial admin user * Keycloak pod resource requests and limits * Additional Java options (JAVA_OPTS) * Prometheus monitoring using an existing prometheus-operator * Postgres database to use. By default a Bitnami Postgres is installed using the default storage class in the cluster. Note: Using an external database depends on Commodore support for making postprocessing filters optional, cf. projectsyn/commodore#155.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can be helpful to make postprocessing components optional based on a reclass reference.
This PR implements this feature by introducing an optional field
enabledfor each filter definition. If the field doesn't exist, filters will count as enabled. This feature is particularly useful if we want to apply a filter to a subchart of a Helm chart which can be enabled or disabled, e.g. Postgres for Keycloak.The PR also introduces a first set of tests for
postprocess_components.Checklist