fix: remove usage of deprecated function aws.EndpointResolverWithOptionsFunc#3700
Merged
rchincha merged 1 commit intoproject-zot:mainfrom Jan 15, 2026
Merged
fix: remove usage of deprecated function aws.EndpointResolverWithOptionsFunc#3700rchincha merged 1 commit intoproject-zot:mainfrom
rchincha merged 1 commit intoproject-zot:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3700 +/- ##
==========================================
- Coverage 91.58% 91.58% -0.01%
==========================================
Files 186 186
Lines 26499 26490 -9
==========================================
- Hits 24270 24261 -9
Misses 1444 1444
Partials 785 785 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR replaces the deprecated aws.EndpointResolverWithOptionsFunc with the newer BaseEndpoint option for configuring custom AWS service endpoints in DynamoDB and Secrets Manager clients.
Changes:
- Removes deprecated endpoint resolver implementation and associated
//nolint: staticcheckcomments - Implements endpoint configuration using the
BaseEndpointfield in client options - Updates test files to use the new endpoint configuration pattern
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/storage/cache/dynamodb.go | Replaces deprecated endpoint resolver with BaseEndpoint configuration for DynamoDB cache client |
| pkg/meta/dynamodb/parameters.go | Updates GetDynamoClient function to use BaseEndpoint instead of deprecated resolver |
| pkg/meta/dynamodb/dynamodb_test.go | Modifies test to configure endpoint using BaseEndpoint option |
| pkg/meta/dynamodb/dynamodb_internal_test.go | Updates multiple test cases to use BaseEndpoint for endpoint configuration |
| pkg/extensions/imagetrust/image_trust.go | Migrates Secrets Manager client creation to use BaseEndpoint option |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…onsFunc Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also #2888
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.