fix: update go-redsync for fips-140 compatibility#3451
fix: update go-redsync for fips-140 compatibility#3451andaaron merged 3 commits intoproject-zot:mainfrom
Conversation
|
Should we just make this default in our container images? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3451 +/- ##
=======================================
Coverage 90.87% 90.87%
=======================================
Files 183 183
Lines 33327 33330 +3
=======================================
+ Hits 30287 30290 +3
Misses 2294 2294
Partials 746 746 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I suggest we also emit a log message stating fips is on, in case it is on, just to validate. And verify that in bats. Maybe use https://pkg.go.dev/crypto/fips140#Enabled |
{"time":"2025-10-12T08:46:58.596597075-07:00","level":"info","message":"fips140 is currently enabled","goroutine":1,"caller":"zotregistry.dev/zot/pkg/cli/server/root.go:57","func":"zotregistry.dev/zot/pkg/cli/server.NewServerRootCmd.newServeCmd.func2"} |
Fixes issue project-zot#3445 Signed-off-by: Ramkumar Chinchani <rchincha.dev@gmail.com>
I dont' know if that is something we want. Given https://go.dev/doc/security/fips140:
|
Signed-off-by: Ramkumar Chinchani <rchincha.dev@gmail.com>
Signed-off-by: Ramkumar Chinchani <rchincha.dev@gmail.com>
Fixes issue #3445
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.