New symbols, plus fixes#213
Merged
Merged
Conversation
* use conventional generated file banner * protocols live in files with _protocol in the filename * dropped convenience alloc functions * renamed type for protocol wrapper to end with Object instead of Wrapper * ensure protocol wrappers implement the protocol interface * constants with same name as their enum name get K prefix * globbergen finds files by filename now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is primarily about a new symbolsdb that has a fix to a bug where symbols with the same names were collapsed to one. Resolving this adds 6 new class/prototypes, 14 new constants, and most importantly adds 1,681 missing methods.
A few other fixes are included:
Lastly, the regen in this PR looks like it changed more than it did because the new symbolsdb has a new ordering causing the order of definitions to change. From here regeneration should maintain this order and won't be as significant a diff in the future.