angleMode not saved/restored by push/pop

[bobcgausa]

Most appropriate sub-area of p5.js?

• Accessibility (Web Accessibility)
• Build tools and processes
• Color
• [X ] Core/Environment/Rendering
• Data
• DOM
• Events
• Friendly error system
• Image
• IO (Input/Output)
• Localization
• [X ] Math
• Unit Testing
• Typography
• Utilities
• WebGL
• Other (specify if possible)

Details about the bug:

My library sets angleMode to degrees, which can have side effects if user has set it to radians.
You might say, ok reset to radians after use, but what if user had set to degrees?
Two fixes:
Have angleMode return previous angleMode so i can save and restore
or
Save/restore angleMode in push/pop

[stalgiag]

Hi @bobcgausa ! Thanks for the issue. I agree that angleMode should be captured by push and pop. Here is an example that shows the problem.

[DavidWeiss2]

I would love to try to fix it.
Do I need to both change:
p5.Renderer.js
p5.Renderer2D.js
p5.RendererGL.js
?

[bobcgausa]

The rule is that library methods should not have side effects, such as changing angleMode, unless the changes are documented. Since angleMode is a math function, the update should not be restricted to push/pop. The reason is that a math library function should not have to call push/pop to save the environment. Thus, in addition to push/pop change, angleMode should return the previous angleMode.

…

________________________________ From: David Weiss ***@***.***> Sent: Monday, April 12, 2021 4:41 AM To: processing/p5.js ***@***.***> Cc: bobcgausa ***@***.***>; Mention ***@***.***> Subject: Re: [processing/p5.js] angleMode not saved/restored by push/pop (#5160) I would love to try to fix it. Do I need to both change: p5.Renderer.js p5.Renderer2D.js p5.RendererGL.js ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fprocessing%2Fp5.js%2Fissues%2F5160%23issuecomment-817612912&data=04%7C01%7C%7C45645e5b3f6542ee349608d8fd8ec7fb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637538136965770631%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=BOy6VkAQtaRuTyTMhJTY81miMhgILBjtlZ3UZY0a%2BUY%3D&reserved=0>, or unsubscribe<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAUCTBCC3SRLQ5EDX3PVX2DTIKW35ANCNFSM42M276YQ&data=04%7C01%7C%7C45645e5b3f6542ee349608d8fd8ec7fb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637538136965780626%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=5V9FlbVQjZgU7fdPhulbS3wHzczfSHbChU%2FiTMZ8PMk%3D&reserved=0>.

[DavidWeiss2]

So maybe we will add an option to add functions to a push()/pop().
Like:

push.add(angleMode)

and the life span of this function will be until a

push.remove(angleMode)

Will be called.

This will also give an option to exclude a state, like color() you don't want the push/pop to affect.

[stalgiag]

Unless I am misunderstanding something, you should be able to add angleMode to the properties returned by p5.Renderer.push to get the expected behavior.

[bobcgausa]

But still forces math only funcs to use mostly graphic push popPersonally, I would just change AngleMode to return previous modeOn Apr 12, 2021 9:43 AM, David Weiss ***@***.***> wrote: So maybe we will add an option to add functions to a push()/pop(). Like: push.add(angleMode) and the life span of this function will be until a push.remove(angleMode) Will be called. This will also give an option to exclude a state, like color() you don't want the push/pop to affect. —You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.

[DavidWeiss2]

So how do you want to address it?

…

On Mon, Apr 12, 2021, 17:02 bobcgausa ***@***.***> wrote: But still forces math only funcs to use mostly graphic push popPersonally, I would just change AngleMode to return previous modeOn Apr 12, 2021 9:43 AM, David Weiss ***@***.***> wrote: So maybe we will add an option to add functions to a push()/pop(). Like: push.add(angleMode) and the life span of this function will be until a push.remove(angleMode) Will be called. This will also give an option to exclude a state, like color() you don't want the push/pop to affect. —You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5160 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADBVIS2F2CAFQOOPTPAYIC3TIL4PRANCNFSM42M276YQ> .

[bobcgausa]

Adding return to anglemode affects noone and can be added immediately.I would get more opinions on any push changeOn Apr 12, 2021 10:17 AM, David Weiss ***@***.***> wrote: So how do you want to address it?

On Mon, Apr 12, 2021, 17:02 bobcgausa ***@***.***> wrote: But still forces math only funcs to use mostly graphic push popPersonally, I would just change AngleMode to return previous modeOn Apr 12, 2021 9:43 AM, David Weiss ***@***.***> wrote: So maybe we will add an option to add functions to a push()/pop(). Like: push.add(angleMode) and the life span of this function will be until a push.remove(angleMode) Will be called. This will also give an option to exclude a state, like color() you don't want the push/pop to affect. —You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5160 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADBVIS2F2CAFQOOPTPAYIC3TIL4PRANCNFSM42M276YQ> .

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.

[limzykenneth]

Adding a return to angleMode() call without argument should be a doable solution.