Skip to content

pr05 Typescript Migration #5: Migrate client/common folder #3565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

clairep94
Copy link
Collaborator

@clairep94 clairep94 commented Aug 3, 2025

pr05 Typescript Migration 5: Migrate the client/commonfolder

Context:

  1. git mv someComponent.jsx someComponent.tsx. If possible, commit without the no-verify flag, otherwise with no-verify.
  2. Add unit test to secure current behaviour
  3. Check for all instances of useage for the common component to determine props types
  4. Add props types & unit test update
  5. Refactor if beneficial -- did minimal refactoring on this one compared to previous PRs and focused on typescript
  6. Add JSDocs

Changes:

  • .prettierrc -- remove hardcoded parser: "babel" setting
    • This was causing prettier to always use babel even though eslint config has overrides for ts and tsx files
  • RouterTab
  • Button
  • ButtonOrLink
  • IconButton
  • icon
    • was not able to figure out how to migrate this as just updating the file to ts broke the snapshot tests for the generated classes
  • usePrevious
  • useKeyDownHandler
  • onModalClose
  • useSyncFormTranslation

Didn't migrate the storebook files as I wasn't able to run storybook locally to verify against silent regression

Notes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@clairep94 clairep94 added the pr05 Grant Projects pr05 Grant Projects label Aug 3, 2025
@clairep94 clairep94 marked this pull request as ready for review August 3, 2025 13:04
@clairep94
Copy link
Collaborator Author

@raclim @khanniie Ready for review! Can be reviewed separately from the utils folder migration PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr05 Grant Projects pr05 Grant Projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant