Skip to content

Fix PropTypes.object() linting errors #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
catarak merged 4 commits into from
Nov 25, 2020
Merged

Fix PropTypes.object() linting errors #1692

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a7b2bd
Fix PropTypes.object() linting errors
KKVANONYMOUS Nov 24, 2020
1ecb3db
Add isRequired in the snippets specified
KKVANONYMOUS Nov 25, 2020
942b6dc
Merge branch 'develop' into develop
KKVANONYMOUS Nov 25, 2020
5c3d823
[#1514] Update PropType for ActionStrip.icon
catarak Nov 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/components/mobile/ActionStrip.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const ActionStrip = ({ actions }) => (

ActionStrip.propTypes = {
actions: PropTypes.arrayOf(PropTypes.shape({
icon: PropTypes.any,
icon: PropTypes.any, //eslint-disable-line
Copy link
Member

@catarak catarak Nov 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to fix this so that you don't have to disable linting on this line?

Copy link
Contributor Author

@KKVANONYMOUS KKVANONYMOUS Nov 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@catarak I think in order to resolve it we have to explicitly specify the data type of icon field.
Can you please tell me which data type does it use?

Copy link
Member

@catarak catarak Nov 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be PropTypes.component! I fixed it 😄

aria: PropTypes.string.isRequired,
action: PropTypes.func.isRequired,
inverted: PropTypes.bool
Expand Down
2 changes: 1 addition & 1 deletion client/modules/IDE/components/NewFileForm.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class NewFileForm extends React.Component {

NewFileForm.propTypes = {
fields: PropTypes.shape({
name: PropTypes.object.isRequired
name: PropTypes.objectOf(PropTypes.shape())
}).isRequired,
handleSubmit: PropTypes.func.isRequired,
createFile: PropTypes.func.isRequired,
Expand Down
2 changes: 1 addition & 1 deletion client/modules/IDE/components/NewFolderForm.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class NewFolderForm extends React.Component {

NewFolderForm.propTypes = {
fields: PropTypes.shape({
name: PropTypes.object.isRequired
name: PropTypes.objectOf(PropTypes.shape())
}).isRequired,
handleSubmit: PropTypes.func.isRequired,
createFolder: PropTypes.func.isRequired,
Expand Down
2 changes: 1 addition & 1 deletion client/modules/IDE/pages/IDEView.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ IDEView.propTypes = {
updatedAt: PropTypes.string,
}).isRequired,
editorAccessibility: PropTypes.shape({
lintMessages: PropTypes.array.isRequired, // eslint-disable-line
lintMessages: PropTypes.objectOf(PropTypes.shape()),
}).isRequired,
preferences: PropTypes.shape({
autosave: PropTypes.bool.isRequired,
Expand Down
4 changes: 2 additions & 2 deletions client/modules/User/components/APIKeyForm.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import CopyableInput from '../../IDE/components/CopyableInput';
import APIKeyList from './APIKeyList';

export const APIKeyPropType = PropTypes.shape({
id: PropTypes.object.isRequired, // eslint-disable-line
token: PropTypes.object, // eslint-disable-line
id: PropTypes.objectOf(PropTypes.shape()),
token: PropTypes.objectOf(PropTypes.shape()),
label: PropTypes.string.isRequired,
createdAt: PropTypes.string.isRequired,
lastUsedAt: PropTypes.string
Expand Down
8 changes: 4 additions & 4 deletions client/modules/User/components/AccountForm.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,10 @@ function AccountForm(props) {

AccountForm.propTypes = {
fields: PropTypes.shape({
username: PropTypes.object.isRequired, // eslint-disable-line
email: PropTypes.object.isRequired, // eslint-disable-line
currentPassword: PropTypes.object.isRequired, // eslint-disable-line
newPassword: PropTypes.object.isRequired, // eslint-disable-line
username: PropTypes.objectOf(PropTypes.shape()),
email: PropTypes.objectOf(PropTypes.shape()),
currentPassword: PropTypes.objectOf(PropTypes.shape()),
newPassword: PropTypes.objectOf(PropTypes.shape()),
}).isRequired,
user: PropTypes.shape({
verified: PropTypes.string.isRequired,
Expand Down
4 changes: 2 additions & 2 deletions client/modules/User/components/LoginForm.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ function LoginForm(props) {

LoginForm.propTypes = {
fields: PropTypes.shape({
email: PropTypes.object.isRequired, // eslint-disable-line
password: PropTypes.object.isRequired, // eslint-disable-line
email: PropTypes.objectOf(PropTypes.shape()),
password: PropTypes.objectOf(PropTypes.shape()),
}).isRequired,
handleSubmit: PropTypes.func.isRequired,
validateAndLoginUser: PropTypes.func.isRequired,
Expand Down
4 changes: 2 additions & 2 deletions client/modules/User/components/NewPasswordForm.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ function NewPasswordForm(props) {

NewPasswordForm.propTypes = {
fields: PropTypes.shape({
password: PropTypes.object.isRequired, // eslint-disable-line
confirmPassword: PropTypes.object.isRequired, // eslint-disable-line
password: PropTypes.objectOf(PropTypes.shape()),
confirmPassword: PropTypes.objectOf(PropTypes.shape()),
}).isRequired,
handleSubmit: PropTypes.func.isRequired,
updatePassword: PropTypes.func.isRequired,
Expand Down
2 changes: 1 addition & 1 deletion client/modules/User/components/ResetPasswordForm.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ function ResetPasswordForm(props) {

ResetPasswordForm.propTypes = {
fields: PropTypes.shape({
email: PropTypes.object.isRequired
email: PropTypes.objectOf(PropTypes.shape())
}).isRequired,
handleSubmit: PropTypes.func.isRequired,
initiateResetPassword: PropTypes.func.isRequired,
Expand Down
8 changes: 4 additions & 4 deletions client/modules/User/components/SignupForm.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,10 @@ function SignupForm(props) {

SignupForm.propTypes = {
fields: PropTypes.shape({
username: PropTypes.object.isRequired, // eslint-disable-line
email: PropTypes.object.isRequired, // eslint-disable-line
password: PropTypes.object.isRequired, // eslint-disable-line
confirmPassword: PropTypes.object.isRequired, // eslint-disable-line
username: PropTypes.objectOf(PropTypes.shape()),
email: PropTypes.objectOf(PropTypes.shape()),
password: PropTypes.objectOf(PropTypes.shape()),
confirmPassword: PropTypes.objectOf(PropTypes.shape()),
}).isRequired,
handleSubmit: PropTypes.func.isRequired,
signUpUser: PropTypes.func.isRequired,
Expand Down