-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add installation.md Korean Translation #1357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add installation.md Korean Translation #1357
Conversation
My suggestion in #1356 also affects this PR! |
… into add-installation-ko-translation
…mjaything/p5.js-web-editor into add-installation-ko-translation
same here! I'll add future translations in the same way too! |
I think the contents of |
My mistake! Thanks, restored it! |
Hmmm, do you think that |
I agree with you that these documents that belong to Before talking about the ideal file structure of translated documents and files for internationalization, I'm not 100% sure what you mean that Github requires files to be in certain places. I've found out that community health files(CONTRIBUTING, CODE_OF_CONDUCT and etc) should be in the root or in Do you mean that translated community health files should also be in these folders, for above reasons? I've checked to see if there's any feature in github that detects preferred language of the user and displays these community health files in certain language. There were some people asking for such feature, but there isn't one yet. Please let me know if there are other reasons to put certain translated files in certain places. :-) |
If we don't have any constrains, we could organize files as we like. It's probably too early, but maybe organization for files related to internationalization other than documentation should also be taken into account. There doesn't seem to be constraints on location of files when loading translations. At least for i18next, you can configure the path to resources, according to the i18next-gitbook. I've collected several tips on file organization, to have clearer idea on this issue:
|
For now, as we don't have definite file structure for internationalization files other than documentation, I think it would be good enough to put translated If there is a need for significant change in file structure due to to-be-added internationalization files, we could rearrange things. I don't think it would be too complicated. Please let me know what you think! :-) I've looked into several (fully and partially) localized projects to see how they organize files. Just in case this might be useful in the future, I will share several possible options that I have observed from other projects. a) Inside b) Inside c) For translated documents, create folders for each language inside d) In each original directory, put translated files with language abbreviation in the file name. e) Create separate repository for translated documentation, and simply put link to it in README. Some deploys website for documentation. |
I have verified that this pull request:
npm run lint
)Fixes #123
Addresses #1350