Skip to content

File upload shows progress bar instead of checkmark when complete #2240

@lindapaiste

Description

@lindapaiste

p5.js version

No response

What is your operating system?

None

Web browser and version

No response

Actual Behavior

While investigating #2040 I came across an issue with the rendering of completed uploads:

I did find one thing which we are doing wrong, though I don't think it fixes your issue. It's supposed to stop showing the progress bar when the upload is done and show a check mark instead. That doesn't happen because we are overriding the complete function instead of adding a secondary event handler. Therefore the default complete behavior is not called and the dz-complete class never gets added.
https://github.com/dropzone/dropzone/blob/f50d1828ab5df79a76be00d1306cc320e39a27f4/src/options.js#L769-L776

https://docs.dropzone.dev/configuration/events#overriding-default-event-handlers

#2040 (comment)

The checkmark animates in for a moment and then goes away. The upload bar remains.
image

Expected Behavior

This is what it's supposed to to look like, according to the Dropzone documentation.
image

Steps to reproduce

Steps:

  1. Click "Upload File"
  2. Upload a file

Metadata

Metadata

Assignees

Labels

BugError or unexpected behaviors

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions