-
Notifications
You must be signed in to change notification settings - Fork 186
Feature to extract players ID in FBREF #806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #806 +/- ##
===========================================
+ Coverage 59.33% 73.75% +14.41%
===========================================
Files 11 26 +15
Lines 1633 2496 +863
Branches 336 341 +5
===========================================
+ Hits 969 1841 +872
+ Misses 610 575 -35
- Partials 54 80 +26 ☔ View full report in Codecov by Sentry. |
|
I would actually prefer only including the player id in the output, as discussed here: #728. This is more compact and it still allows reconstructing the URL. Furthermore, I would not make this optional and would do it for all functions, not only for |
46acb70 to
5ee4e54
Compare
|
Hi @probberechts ! After your recommendations, I did something cleaner. I added the option to get the player ID directly from the html parsing function. Could you tell me which other functions would benefit from this feature apart from |
|
@probberechts coming back on this, are you able to merge it soon ? |
This PR adds an option in the
read_player_season_statsmethod. When extracting player statistics, it may be interesting to get the URL to the player page as well. This way, we can get additional information in our application with a simple scraping on the player page (for instance, the player picture).