Add unique ids on each textarea to fix announcement issues#3881
Merged
llastflowers merged 2 commits intoJan 26, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 0120454 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an accessibility issue where screen readers were announcing all labels at once when focusing the first textarea in the TextArea Options story. The issue was caused by all textarea examples using the same name, resulting in duplicate IDs being generated.
Changes:
- Added unique
idandnameattributes to all TextArea examples in the preview file to ensure proper label-to-input associations for screen readers
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TylerJDev
approved these changes
Jan 26, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Integration
N/A
List the issues that this change affects.
Addresses https://github.com/github/accessibility-audits/issues/14764
Risk Assessment
What approach did you choose and why?
The labels for all of the textareas on the page were being announced at once when focusing the first example on the page (and not announced on any of the others), because the examples did not have unique ids. This adds unique ids so that the labels are announced correctly when the corresponding textarea is focused.
Issues can be observed here by turning on SR and focusing each of the textareas in turn.
Anything you want to highlight for special attention from reviewers?
N/A
Accessibility
Fix for a11y audit remediation issue
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.