Update ActionList.examples.stories.tsx to no longer use styled-components #6544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llastflowers
added
skip changeset
This comment was marked as resolved.
This comment was marked as resolved.
size-limit report 📦
|
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the ActionList examples stories from using styled-components to CSS modules, supporting the broader effort to remove styled-components from the codebase. The changes replace inline sx props and Box components with CSS module classes while maintaining the same visual styling and functionality.
- Replaces styled-components usage with CSS module classes
- Removes dependency on the
Boxcomponent - Maintains existing styling through equivalent CSS rules
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/react/src/ActionList/ActionList.examples.stories.tsx | Updates component styling from sx props to CSS module classes and replaces Box with div |
| packages/react/src/ActionList/ActionList.examples.stories.module.css | New CSS module file containing equivalent styles for the migrated components |
|
|
||
| .AsyncListNoMatch { | ||
| display: block; | ||
| font-size: var(--text-body-size-medium); |
There was a problem hiding this comment.
The CSS variable --text-body-size-medium may not match the original fontSize: 1 from the sx prop. In the styled-system, fontSize: 1 typically maps to a smaller font size than medium. Verify this mapping is correct.
Suggested change
| font-size: var(--text-body-size-medium); | |
| font-size: var(--text-body-size-small); |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/5667
Changelog
New
Added new CSS module
Changed
Changed
ActionList.examples.stories.tsxto no longer use styled-componentsRemoved
Removed anything associated with styled-components
Rollout strategy
Testing & Reviewing
Merge checklist