Update Textarea stories to no longer use styled-components #6513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llastflowers
added
skip changeset
This comment was marked as resolved.
This comment was marked as resolved.
size-limit report 📦
|
llastflowers
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR removes dependencies on styled-components from Textarea Storybook stories by replacing Box components with native HTML form elements and replacing the sx prop with CSS modules for styling.
- Removed
Boxcomponent imports and usage across three story files - Created a new CSS module file for custom styling previously handled by the
sxprop - Replaced styled-components approach with native HTML elements and CSS modules
Reviewed Changes
Copilot reviewed 4 out of 8 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react/src/Textarea/Textarea.stories.tsx | Removed Box import and replaced Box as="form" with native form elements |
| packages/react/src/Textarea/Textarea.features.stories.tsx | Removed Box import and replaced all Box as="form" instances with native form elements |
| packages/react/src/Textarea/Textarea.dev.stories.tsx | Removed Box import, replaced Box as="form" with form, and replaced sx prop with CSS module class |
| packages/react/src/Textarea/Textarea.dev.stories.module.css | Added new CSS module with background color styling to replace sx prop usage |
jonrohan
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/5639
Closes https://github.com/github/primer/issues/5640
Closes https://github.com/github/primer/issues/5641
Changelog
New
Added new CSS module
Changed
Changed
Textarea.stories.tsxandTextarea.dev.stories.tsxandTextarea.features.stories.tsxto no longer use styled-componentsRemoved
Removed anything associated with styled-components
Rollout strategy
Testing & Reviewing
Merge checklist