Skip to content

Stack: Add shrink prop to Stack.Item #6260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2025
Merged

Conversation

adierkens
Copy link
Contributor

@adierkens adierkens commented Jul 1, 2025

Closes https://github.com/github/primer/issues/5139

Changelog

New

Adds the ability to supply a shrink prop to Stack.Item to control sizing behaviors when the content width exceeds the available space. It maintains the current default behavior (flex-shrink: 1)

Before/After Screenshot of adding the shrink property to a stack-item

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Merge checklist

@Copilot Copilot AI review requested due to automatic review settings July 1, 2025 14:57
@adierkens adierkens requested a review from a team as a code owner July 1, 2025 14:57
@adierkens adierkens requested a review from TylerJDev July 1, 2025 14:57
Copy link

changeset-bot bot commented Jul 1, 2025

🦋 Changeset detected

Latest commit: bb82603

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 1, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 1, 2025
Copy link
Contributor

github-actions bot commented Jul 1, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.38 KB (-0.11% 🔽)
packages/react/dist/browser.umd.js 92.52 KB (-0.2% 🔽)

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@joshblack joshblack requested a review from langermank July 1, 2025 19:18
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! 🙌 Also tagged in @langermank to review, just wanted her to have a chance to review before merging

Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets goooo! 🚀

@@ -468,58 +469,42 @@ export const Playground: Story = {
},
}

function createArgMetaData(category: string): InputType {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh this is so clean 😍

@adierkens adierkens added this pull request to the merge queue Jul 14, 2025
Merged via the queue into main with commit 8210573 Jul 14, 2025
35 checks passed
@adierkens adierkens deleted the adierkens/stack-item-shrink branch July 14, 2025 15:19
@primer primer bot mentioned this pull request Jul 12, 2025
llastflowers pushed a commit that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants