-
Notifications
You must be signed in to change notification settings - Fork 626
Stack: Add shrink
prop to Stack.Item
#6260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: bb82603 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! 🙌 Also tagged in @langermank to review, just wanted her to have a chance to review before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets goooo! 🚀
@@ -468,58 +469,42 @@ export const Playground: Story = { | |||
}, | |||
} | |||
|
|||
function createArgMetaData(category: string): InputType { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh this is so clean 😍
Closes https://github.com/github/primer/issues/5139
Changelog
New
Adds the ability to supply a
shrink
prop toStack.Item
to control sizing behaviors when the content width exceeds the available space. It maintains the current default behavior (flex-shrink: 1
)Rollout strategy
Merge checklist