-
Notifications
You must be signed in to change notification settings - Fork 625
SelectPanel: Add focus indicator SelectPanel items #6259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 5fa377a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than VRT failures!
5365090
to
5fa377a
Compare
https://github.com/github/accessibility-audits/issues/11962
Ensures focus indicator is added to
SelectPanel
item(s). Since we intend foraria-disabled
items to still remain focusable, they should receive the same focus styles as other focusable items.Changelog
Changed
SelectPanel
itemsRollout strategy
Testing & Reviewing
Merge checklist