Skip to content

SelectPanel: Add focus indicator SelectPanel items #6259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 1, 2025

Conversation

TylerJDev
Copy link
Member

https://github.com/github/accessibility-audits/issues/11962

Ensures focus indicator is added to SelectPanel item(s). Since we intend for aria-disabled items to still remain focusable, they should receive the same focus styles as other focusable items.

Changelog

Changed

  • Adds focus indicator to SelectPanel items

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@Copilot Copilot AI review requested due to automatic review settings July 1, 2025 12:35
@TylerJDev TylerJDev requested a review from a team as a code owner July 1, 2025 12:35
@TylerJDev TylerJDev requested a review from francinelucca July 1, 2025 12:35
Copy link

changeset-bot bot commented Jul 1, 2025

🦋 Changeset detected

Latest commit: 5fa377a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Jul 1, 2025
@TylerJDev TylerJDev changed the title Tylerjdev/add focus indicator select panel SelectPanel: Add focus indicator SelectPanel items Jul 1, 2025
Copy link
Contributor

github-actions bot commented Jul 1, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 1, 2025
Copy link
Contributor

github-actions bot commented Jul 1, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.48 KB (0%)
packages/react/dist/browser.umd.js 92.7 KB (0%)

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than VRT failures!

@TylerJDev TylerJDev force-pushed the tylerjdev/add-focus-indicator-select-panel branch from 5365090 to 5fa377a Compare July 1, 2025 15:49
@TylerJDev TylerJDev added this pull request to the merge queue Jul 1, 2025
Merged via the queue into main with commit ad6a52c Jul 1, 2025
35 checks passed
@TylerJDev TylerJDev deleted the tylerjdev/add-focus-indicator-select-panel branch July 1, 2025 16:52
@primer primer bot mentioned this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants