-
Notifications
You must be signed in to change notification settings - Fork 625
fix: remove min height calc logic for SelectPanel #6225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: f4387ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@francinelucca Tagging you here as we are already discussing reg this 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the dynamic min-height calculation for the SelectPanel
component, simplifying its sizing behavior and dropping the heightMap
dependency.
- Deleted the
heightMap
import fromOverlay
- Removed the
--max-height
inline style that set panel height based onoverlayProps.maxHeight
Files not reviewed (1)
- packages/react/src/SelectPanel/SelectPanel.module.css: Language not supported
Comments suppressed due to low confidence (2)
packages/react/src/SelectPanel/SelectPanel.tsx:23
- With the removal of
heightMap
and--max-height
logic, please update the SelectPanel documentation (PropTable and website docs) to reflect thatmaxHeight
is no longer used for sizing.
import {announce, announceFromElement} from '@primer/live-region-element'
packages/react/src/SelectPanel/SelectPanel.tsx:722
- Add or update unit/visual regression tests to verify that SelectPanel renders correctly with default sizing and that removing the
--max-height
style doesn’t introduce layout regressions.
style: {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Marie Lucca <[email protected]>
Closes #6220
Changelog
New
Changed
Removed
SelectPanel
Rollout strategy
Testing & Reviewing
Merge checklist